[Sync-EN] Clarify ldap_connect(), ldap_bind() and ldap_set_option() behavior - #1795
Open
lacatoire wants to merge 1 commit into
Open
[Sync-EN] Clarify ldap_connect(), ldap_bind() and ldap_set_option() behavior#1795lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the three
reference/ldap/functions/pages with php/doc-en#5275.ldap_connect(): says explicitly that it opens no network connection, only validating the URI and initializing connection parameters, the TCP connection being established byldap_bind(). A second note states that connection-setup options,LDAP_OPT_PROTOCOL_VERSIONand theLDAP_OPT_X_TLS_*family, must be set betweenldap_connect()andldap_bind(), the TLS ones globally.ldap_bind(): gains the matching note, that it is the call establishing the connection, so connection-affecting options must be set beforehand.ldap_set_option(): gains the note thatLDAP_OPT_X_TLS_*options must be set globally by passingnullasldap, because the TLS context is initialized before the per-connection state exists, and beforeldap_bind().EN-Revision bumped to 87d63aa1a3fc86d64dc994332042fdd2c13bf3d8 on the three files.
Fixes: #1651