[Sync-EN] Fix the OPENSSL_RAW_DATA description for encrypt and decrypt - #1796
Open
lacatoire wants to merge 1 commit into
Open
[Sync-EN] Fix the OPENSSL_RAW_DATA description for encrypt and decrypt#1796lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
reference/openssl/constants.xml,reference/openssl/functions/openssl-decrypt.xmlandreference/openssl/functions/openssl-encrypt.xmlwith php/doc-en#5268.OPENSSL_RAW_DATAconstant said the data "is returned as-is" and that base64 is "returned to the caller", which only describesopenssl_encrypt(). Foropenssl_decrypt()the flag describes the input format. The constant now states the general meaning and points at the function pages.optionsdescriptions say the parameter is a bitwise disjunction of the three flags, instead of "one of the constants", and each spells out its own direction:openssl_decrypt()expects raw binary ciphertext indatawhen the flag is set and base64 otherwise, whileopenssl_encrypt()returns raw binary output when set and base64 otherwise.EN-Revision bumped to 7179e95e592583beae2f99ca71e6b326f559812b on the three files.
Fixes: #1653