[Sync-EN] Document the procedural style of IntlGregorianCalendar methods - #1797
Open
lacatoire wants to merge 1 commit into
Open
[Sync-EN] Document the procedural style of IntlGregorianCalendar methods#1797lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the three
reference/intl/intlgregoriancalendar/pages with php/doc-en#5619.The three pages carried an empty description with
&warn.undocumented.func;. They now document both styles and the behaviour:getGregorianChange()/intlgregcal_get_gregorian_change(): the Gregorian change date, the point at which the calendar switches from Julian to Gregorian dates, as a Unix timestamp in milliseconds, defaulting to midnight UTC on 15 October 1582.isLeapYear()/intlgregcal_is_leap_year(): whether the given year is a leap year in the Gregorian calendar, with theyearparameter finally described.setGregorianChange()/intlgregcal_set_gregorian_change(): sets that date, withtimestampdescribed.Each page gains the
&style.oop;and&style.procedural;markers and thecalendarparameter of the procedural form.EN-Revision bumped to a9a5a377cfbff431de8bbdca1a2b7a51c7500ca1 on the three files.
Fixes: #1656