ext/soap: various minor refactorings (2026-07#1)#22566
Merged
Girgias merged 9 commits intoJul 3, 2026
Merged
Conversation
This removes some reallocations by being able to just increase a refcount
Use zend_string* rather than a pair and remove unused param
- Add const qualifiers - Reduce scope of variable - Reuse computed strlen() - Use uint32_t type instead of int type
devnexen
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits should be reviewed one by one.
Is that time of year when I try to make sense of this extension and remove bailouts from it before I inevitably fail.
Maybe I'll make a bit more progress this time.