Repository navigation
Conversation
Truta446
left a comment
There was a problem hiding this comment.
Tested this on current master (Linux x86_64, debug NTS): 300/300 isolated runs pass on an idle machine. With all 24 cores busy, 297/300 pass on the first attempt; the other 3 fail once and pass on run-tests' automatic retry (the test calls
usleep(), sois_flaky()retries it), which is reported as a WARN and does not fail the job. 25 runs of the wholesapi/fpm/testssuite with-j4under the same load had no failures. So it's still slightly timing-sensitive under heavy load, but dropping XFAIL turns a permanent "XFAIL section but test passes" warning into a rare "passed on retry" one. 👍
|
We had actually CI failures for this test on slow CI. I just looked into it more and trying this instead: #24998 . Just removing XFAIL is not correct so closing this. |
76ca6bf removed, ea3a317 fixed race, c4639a2 restored with "Still fails intermittently" (6y ago). Later 1029537 and 4580b8b landed which could be related. Analysed 16,457 CI invocations, ran it thousands of times locally -- at least in CI and locally (macOS) it never fails but warns "XFAIL section but test passes". Worth trying the removal again. If a OS/local specific report hits we can try fixing it properly rather than sledgehammering with XFAIL.