Repository navigation
Fix GH-24674: var_destroy(): hold serialize_lock around deferred destructor pass - #24693
Open
HoneyTyagii wants to merge 1 commit into
Open
HoneyTyagii wants to merge 1 commit into
HoneyTyagii wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Member
|
The GH-24674 reproducers still read the outer context with this applied on master: their destructor runs from object_common() when the __unserialize() payload fails to parse, while the context is still registered, not from var_destroy(). #24751 fixes those; 08f4b64 already unregisters the context before var_destroy() runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24674.
The same use-after-free as GH-24481 is reachable through entry points that
create their own var_hash context, such as SplObjectStorage::__unserialize()
(and SplDoublyLinkedList/ArrayObject). var_destroy() frees the var_entries
chain before running the deferred destructor pass; a destructor that calls
unserialize() could reuse the freed chunks. Holding BG(serialize_lock)
around i_zval_ptr_dtor() prevents re-entrancy from reusing the chain being
destroyed.