Skip to content

Fix GH-24740: Unbounded size of .phar/.metadata* entry in TAR phar #24742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lazerg wants to merge 2 commits into
base: master
Choose a base branch
from
+47 −1
Open

Fix GH-24740: Unbounded size of .phar/.metadata* entry in TAR phar #24742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6c7cad
Fix GH-24740: Oversized size in tar .phar/.metadata.bin entry
lazerg Oct 26, 2026
f9030ed
Reword GH-24740 NEWS entry and test title
lazerg Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ PHP NEWS
- Phar:
. Fixed bug GH-22556 (OOM DoS via oversized ././@LongLink entry in TAR phar).
(crystarm)
. Fixed bug GH-24740 (Unbounded size of .phar/.metadata* entry in TAR phar).
(lazerg)

- Readline:
. Fixed a heap over-read in the interactive shell prompt when cli.prompt is
Expand Down
2 changes: 1 addition & 1 deletion ext/phar/tar.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ zend_result phar_parse_tarfile(
}

if (zend_string_starts_with_literal(entry.filename, ".phar/.metadata")) {
if (FAILURE == phar_tar_process_metadata(newentry, fp)) {
if (size > totalsize || FAILURE == phar_tar_process_metadata(newentry, fp)) {
if (error) {
spprintf(error, 4096, "phar error: tar-based phar \"%s\" has invalid metadata in magic file \"%s\"", fname, ZSTR_VAL(entry.filename));
}
Expand Down
44 changes: 44 additions & 0 deletions ext/phar/tests/tar/gh24740.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
--TEST--
GH-24740 (Unbounded size of .phar/.metadata* entry in TAR phar)
--EXTENSIONS--
phar
--INI--
memory_limit=16M
--FILE--
<?php
function tar_header(string $name, int $size): string
{
$header = str_repeat("\0", 512);
$header = substr_replace($header, $name, 0, strlen($name));
$header = substr_replace($header, sprintf("%07o\0", 0644), 100, 8);
$header = substr_replace($header, sprintf("%07o\0", 0), 108, 8);
$header = substr_replace($header, sprintf("%07o\0", 0), 116, 8);
$header = substr_replace($header, sprintf("%011o\0", $size), 124, 12);
$header = substr_replace($header, sprintf("%011o\0", 1700000000), 136, 12);
$header[156] = '0';
$header = substr_replace($header, "ustar\0", 257, 6);
$header = substr_replace($header, "00", 263, 2);

$checksum = 0;
for ($i = 0; $i < 512; $i++) {
$checksum += ($i >= 148 && $i < 156) ? 0x20 : ord($header[$i]);
}

return substr_replace($header, sprintf("%06o\0 ", $checksum), 148, 8);
}

$fname = __DIR__ . '/gh24740.tar';
file_put_contents($fname, tar_header('.phar/.metadata.bin', 0x7FFFFE00) . str_repeat("\0", 1024));

try {
new PharData($fname);
} catch (UnexpectedValueException $e) {
echo $e->getMessage(), "\n";
}
?>
--CLEAN--
<?php
@unlink(__DIR__ . '/gh24740.tar');
?>
--EXPECTF--
phar error: tar-based phar "%sgh24740.tar" has invalid metadata in magic file ".phar/.metadata.bin"
Loading