Repository navigation
Conversation
When curl opaque objects are cloned, the curl handle was only updated if the callback function wasn't null. However, the C handler in PHP remains attached even if the callback was set to NULL (*). So we must unconditionally update the callback data pointer to the new curl handle. (*) We can't set the C handler to NULL unconditionally on stable branches because that invokes a behaviour change (e.g. built in progress bar).
ndossche
commented
Oct 26, 2026
| curl_easy_setopt(ch->cp, CURLOPT_FILE, (void *) ch); | ||
| curl_easy_setopt(ch->cp, CURLOPT_INFILE, (void *) ch); | ||
| curl_easy_setopt(ch->cp, CURLOPT_WRITEHEADER, (void *) ch); | ||
| curl_easy_setopt(ch->cp, CURLOPT_DEBUGDATA, (void *) ch); |
Member
Author
There was a problem hiding this comment.
This is already done now by the php_curl_copy_fcc_with_option CURLOPT_DEBUGDATA code below
ndossche
commented
Oct 26, 2026
| php_curl *ch = (php_curl *)clientp; | ||
| int rval = CURLKHMATCH_MISMATCH; /* cancel connection in case of an exception */ | ||
|
|
||
| if (!ZEND_FCC_INITIALIZED(ch->handlers.sshhostkey)) { |
Member
Author
There was a problem hiding this comment.
This is adjacently related, matches other handlers, otherwise a nulled callback can crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When curl opaque objects are cloned, the curl handle was only updated if the callback function wasn't null. However, the C handler in PHP remains attached even if the callback was set to NULL (*). So we must unconditionally update the callback data pointer to the new curl handle.
(*) We can't set the C handler to NULL unconditionally on stable branches because that invokes a behaviour change (e.g. built in progress bar).