Repository navigation
Conversation
ndossche
approved these changes
Oct 29, 2026
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
I'm surprised this situation happens, any other drivers with this problem?
| enum pdo_param_type param_type; | ||
|
|
||
| if (colno >= stmt->column_count) { | ||
| array_init(return_value); |
Member
Author
There was a problem hiding this comment.
ZVAL_EMPTY_ARRAY(return_value) in older PHPs no? But point taken ;-)
pdo_firebird_stmt_get_column_meta() indexed out_sqlda.sqlvar before the core rejected an out-of-range column. column_count is the number of XSQLVAR slots from XSQLDA_LENGTH(). For an invalid index, the hook now returns success without reading sqlvar, and the core reports SQLSTATE 07009. describe uses a bounded column loop; get_col callers validate the index. param_hook already rejects paramno >= sqld. Returning FAILURE without setting an error here would yield false, because PDO clears the statement error before calling the hook. Fixes phpGH-25006
iliaal
force-pushed
the
fix/gh-25006-getcolumnmeta-bounds
branch
from
October 29, 2026 22:01
42ee12b to
ff737dc
Compare
Member
Author
|
I checked the other in-tree drivers on PHP-8.4: MySQL, PostgreSQL, SQLite, and DB-Lib validate the index; ODBC doesn't use it. |
ndossche
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pdo_firebird_stmt_get_column_meta() indexed out_sqlda.sqlvar[colno] before PDO checked colno against column_count. column_count is the number of XSQLVAR slots allocated with XSQLDA_LENGTH(). A near index read past that allocation and the core then raised SQLSTATE 07009. A far index faulted. The hook now returns an empty array without reading sqlvar when colno is outside that range, and the existing core check raises 07009. describe and get_col are already limited by their callers. param_hook already rejects paramno >= sqld. Returning FAILURE from this hook would return false instead, because the statement error is cleared before the driver runs.
Fixes #25006