Repository navigation
Conversation
Girgias
force-pushed
the
2026-10-alignof
branch
2 times, most recently
from
October 28, 2026 19:37
957e49b to
2c7d164
Compare
Girgias
force-pushed
the
2026-10-alignof
branch
2 times, most recently
from
October 28, 2026 20:32
5d5a647 to
ac6ac96
Compare
As we now require C11
Sadly we cannot fully remove ZEND_SET_ALIGNED() as alignas is not allowed in typedefs.
Girgias
force-pushed
the
2026-10-alignof
branch
from
October 29, 2026 16:05
ac6ac96 to
a333176
Compare
Girgias
changed the title
Girgias
marked this pull request as ready for review
October 29, 2026 16:53
Girgias
requested review from
TimWolla,
bukka,
dstogov and
zeriyoshi
as code owners
October 29, 2026 16:53
TimWolla
reviewed
Oct 29, 2026
| #include "zend_exceptions.h" | ||
| #include "zend_interfaces.h" | ||
| #include "zend_smart_str.h" | ||
| #include <stdalign.h> |
Member
There was a problem hiding this comment.
Should we include this in zend_portability.h instead?
Member
Author
There was a problem hiding this comment.
It already is included in zend_portability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we now require C11