Skip to content

zend_ast: Fix AST printing of qualified names in name lists - #25066

Open
jorgsowa wants to merge 1 commit into
php:PHP-8.4from
jorgsowa:fix-ast-export-name-list-ns
Open

jorgsowa wants to merge 1 commit into
php:PHP-8.4from
jorgsowa:fix-ast-export-name-list-ns

Conversation

@jorgsowa

Copy link
Copy Markdown
Contributor

Fixed AST printing dropping fully qualified and namespace-relative of class names in implements, catch, and trait use lists

@jorgsowa jorgsowa self-assigned this Oct 30, 2026
Comment thread Zend/zend_ast.c
}
}

static ZEND_COLD void zend_ast_export_name_list_ex(smart_str *str, zend_ast_list *list, int indent, const char *separator)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes me wonder whether this needs to be renamed:

Suggested change
static ZEND_COLD void zend_ast_export_ns_name_list_ex(smart_str *str, zend_ast_list *list, int indent, const char *separator)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants