Repository navigation
tree: use correct argument order for allocation functions - #25079
Merged
Merged
Conversation
It is (nmemb, size, offset) not (size, nmemb, offset). Use sizeof(char) instead of 1 For quoting allocations use (lenght*2, sizeof(char), offset) rather than various different combinations.
It is (ptr, nmemb, size, offset) not (ptr, size, nmemb, offset).
It is (nmemb, size) not (size, nmemb). Use sizeof(char) instead of literal 1 in some cases
github-actions
Bot
added
Extension: openssl
Category: Engine
Extension: intl
Extension: hash
Extension: odbc
Extension: pdo (core)
Extension: pdo_firebird
Extension: pdo_pgsql
Extension: pdo_sqlite
Extension: pgsql
Extension: phar
Extension: snmp
Extension: soap
Extension: sockets
Extension: spl
Extension: standard
Category: Optimizer
ABI break
labels
Girgias
marked this pull request as ready for review
October 31, 2026 19:35
Girgias
requested review from
LamentXU123,
NattyNarwhal,
SakiTakamachi,
bukka,
devnexen and
dstogov
as code owners
October 31, 2026 19:35
devnexen
approved these changes
Oct 31, 2026
LamentXU123
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note these changes were done via a manual audit.
The motivation for using
sizeof(char)rather than a literal1is to make the intention clearer, as a plain 1 can also mean "allocate 1 element of this alignment" and determining this meaning is not necessarily immediately obvious.I might have missed some cases, but hopefully it is all of them.