Skip to content

[wontfix] Fix GH-20656 putenv during resource shutdown #25103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kairosci wants to merge 1 commit into from
Closed

[wontfix] Fix GH-20656 putenv during resource shutdown #25103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ext/standard/basic_functions.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,6 +774,9 @@ PHP_FUNCTION(putenv)
zend_argument_value_error(1, "must have a valid syntax");
RETURN_THROWS();
}
if (UNEXPECTED(EG(flags) & EG_FLAGS_IN_RESOURCE_SHUTDOWN)) {
RETURN_FALSE;
}

pe.putenv_string = zend_strndup(setting, setting_len);
if ((p = strchr(setting, '='))) {
Expand Down
17 changes: 17 additions & 0 deletions ext/standard/tests/streams/gh20656.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
--TEST--
GH-20656 (HashTable use-after-destroy in function table via stream wrapper magic __call() with nested redeclaration)
--FILE--
<?php
class Loader {
function stream_open() {
return true;
}
function __call($m, $a) {
$map[$obj] = putenv("LA=Gx$g_lang");
function __call($m, $a) {}
}
}
stream_wrapper_register('abc', 'Loader');
require 'abc://';
?>
--EXPECT--
Loading