Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes the A and C tracing jit failures from GH-24683.
for A, assignment handling can create redundant copies of identical typed constants that end up overwriting a live cv value before a trace guard or side exit.
for C, a reusable expression can remain bound to a cv spill slot even after that cv has been assigned a different value. later cse reuse can then corrupt the observable state.
the changes preserve the constant identity where appropriate, separate reusable expression values from their cv assignments, and safely share spill storage when the optimized live ranges allow it.
i've included regression tests for the original failures, floating-point cse, and spill-frame pressure.
@ChrisOrlando independently tested A+C on an apple m1 against php 8.5.12. A went from 9 wrong results to 0, and C went from 939 wrong results to 0. the larger workload also matched the jit-off result.
B is handled separately in #25085. the combined A+C+B patches fix all three original reproductions.
refs GH-24683.