Repository navigation
Tests for the v0.4.2 failure paths, and the Firestore emulator in CI - #79
Merged
Merged
Conversation
…and the content index - Award validation, retry bounds and ledger failures never mark an uncredited award applied. - The meter answers 500 and charges nothing when the ledger refuses a write. - Award reads map Firestore failures to unavailable, never to a verdict; a contributor without a string uid is unavailable. - The content index backfill resumes from its position, reports progress and refuses corrupt input; the variant probe surfaces corrupt entries. - backfill-content-sha skips a complete index, rescans on request and says how to resume. - The community receipt keeps its journaled novelty verdict across a cancellation and refuses unjudgeable URLs. - Moderation reservations fail as errors, not as the ceiling, without a usable counter. - Dispatch, reward, logout, approval and shared-account link failures leave submissions, sessions and accounts retryable.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
google-cloud-cliemulatorsimage) before the coverage step and setsFIRESTORE_EMULATOR_HOSTfor that step only.*_emulator_test.gosuites now run in CI instead of skipping.Coverage. On the v0.4.2 patch lines, it rises from 84.5% to 95.3% with the emulator running. Codecov reported 83.79% for #78 without it.
Tests
go test -race ./...passes, with and without the emulator;-race, with no failures;