Conversation
|
🚫 Issue-link guardrail failed — this PR has been converted to draft. Every PR must reference a tracking issue in
Add the link with a keyword in the PR description (not in a comment): https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests When fixed, press Ready for review to re-run the checks. |
There was a problem hiding this comment.
🟡 Changes recommended
Two other calls still pass the same nullable path directly to is_file().
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a null guard before validating a local preview file path.
Changes:
- Prevents one nullable path from reaching
is_file().
File summaries
| File | Description |
|---|---|
src/Controller/ConfigDataObjectController.php |
Adds the preview-path guard. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ) { | ||
| $previewFilePath = $this->previewService->getLocalPreviewFile($configName, $this->getPimcoreUser()); | ||
| if (is_file($previewFilePath)) { | ||
| if ($previewFilePath && is_file($previewFilePath)) { |
|
👋 Friendly reminder — this pull request is still a draft. A guardrail converted it to draft because something needed fixing, and there has been no activity since. If nothing changes, it will be closed in 14 days. To keep it open, just take one of these steps:
Closing is not rejection: the branch and the discussion stay, and the PR can be reopened at any time. When fixed, press Ready for review to re-run the checks. |
pimcore-deployments
added
guardrails:stale-draft
and removed
guardrails:stale-draft
labels
|
Changes in this pull request
Resolves #
fix for passing null to is_file function
Additional info