3207 - [Data Importer] - Translations (nl, pl) - #697
Merged
Merged
Conversation
Full translation of studio.en.yaml into nl and pl, consistent with the reviewed studio-ui-bundle translations (shared keys and common UI terms reuse those exact values; glossary pins kept English: Asset, Object Brick, Field Collection, Custom Layout, Layout, Workspace). Validated with the studio i18n skill validator. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several translations contain grammatical errors or conflict with the rollout’s established terminology.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds complete Dutch and Polish translations for the Data Importer Studio UI.
Changes:
- Adds Dutch and Polish translation catalogs.
- Preserves English key order and placeholders.
File summaries
| File | Description |
|---|---|
studio.nl.yaml |
Adds Dutch UI translations. |
studio.pl.yaml |
Adds Polish UI translations. |
Review details
Suppressed comments (4)
src/Resources/translations/studio.pl.yaml:296
- These messages again use English
Classification Store, while this file and the referenced Studio UI translation useMagazyn klasyfikacji; the batch error also repeatsPartiainstead of the statedzbiorczoterminology. Standardize both concepts so the modal matches the target selector and the rollout glossary.
data-importer.mapping.advanced-modal.step-target.classification-store-key-modal.title: Wybierz klucz Classification Store
data-importer.mapping.advanced-modal.step-target.classification-store-key-modal.description: Wyszukaj i wybierz klucz dla tego pola Classification Store
data-importer.mapping.advanced-modal.step-target.type-error.classificationstoreBatch: "Partia Classification Store wymaga typu wyniku transformacji: array, quantityValueArray, inputQuantityValueArray lub dateArray."
src/Resources/translations/studio.pl.yaml:324
- As with the CSV validation message, the substituted field label can have any grammatical gender, making the fixed neuter
wymaganeincorrect for labels such asNazwa użytkownika. MakePolethe grammatical subject so this generic validation remains correct for every label.
data-importer.validation.required: "{{field}} jest wymagane"
src/Resources/translations/studio.nl.yaml:291
- This switches the feature name from
Classificatieopslagat line 243 to EnglishClassification Store. The referenced Studio UI translation consistently usesClassificatieopslag; use that term here as well to avoid two names for the same concept.
data-importer.mapping.advanced-modal.step-target.classification-store-key: Classification Store-sleutel
src/Resources/translations/studio.nl.yaml:296
- These modal strings again revert to English
Classification Store, whereas this file and the referenced Studio UI translation useClassificatieopslag. Standardize the terminology here so the modal and target selector describe the same feature consistently.
data-importer.mapping.advanced-modal.step-target.classification-store-key-modal.title: Classification Store-sleutel selecteren
data-importer.mapping.advanced-modal.step-target.classification-store-key-modal.description: Zoek en selecteer een sleutel voor dit Classification Store-veld
data-importer.mapping.advanced-modal.step-target.type-error.classificationstoreBatch: "Classification Store-batch vereist transformatieresultaattype: array, quantityValueArray, inputQuantityValueArray of dateArray."
- Files reviewed: 2/2 changed files
- Comments generated: 7
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- pl: make "Pole" the grammatical subject of the generic validation messages, so they stay correct for field labels of any gender. - pl: "Atrybuty zrodlowe" instead of a parenthetical that cannot agree with both numbers. - nl+pl: keep the Classification Store product name in English, as all six existing locales in this bundle already do. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds full Dutch (
studio.nl.yaml) and Polish (studio.pl.yaml) Studio UI translations, mirroringstudio.en.yamlkey for key.Part of the nl/pl rollout across all Studio bundles (tracking: #3207, reference PR: pimcore/studio-ui-bundle#4070).
nl/plare deliberately NOT yet in the translation skill'slanguages.yaml— that flip happens last across the rollout.How
{{…}}/%…%/$t(…)preserved verbatim._one/_otherto keep key parity with en (same as all existing locales).Verification
validate_translations.py --dir src/Resources/translations --languages nl,pl: key set, order, placeholders, quoting and plurals match en. Machine translation without native review — sampling welcome.🤖 Generated with Claude Code
Closes pimcore/product-management#1338