Skip to content

[CI] PR Policy thin caller for reusable workflow (2.4) - #698

Merged
berfinyuksel merged 1 commit into
2.4from
pr-policy-thin-caller-2.4
Sep 16, 2026
Merged

berfinyuksel merged 1 commit into
2.4from
pr-policy-thin-caller-2.4

Conversation

@berfinyuksel

Copy link
Copy Markdown
Contributor

Part of pimcore/DevOps-Tasks#43.

Brings the PR Policy thin caller to the 2.4 branch so the milestone check runs from
pimcore/workflows-collection-public/.github/workflows/reusable-pr-policy.yml here as well,
identical to what 2026.x already has. On this branch the file was replaced old inline workflow.

With the reusable workflow, PRs carrying the Skip Milestone Check label are exempt from the
mandatory milestone. The check context is PR Policy / Milestone assigned.

Forward-merge chain after this lands: 2.4 → 2026.2 → 2026.x (the merge into a branch that still has the
old inline file conflicts on this one file; take this version).

@berfinyuksel berfinyuksel added the Skip Milestone Check Exempts this PR from the mandatory milestone requirement label Sep 15, 2026
@berfinyuksel
berfinyuksel marked this pull request as ready for review September 15, 2026 15:36
Copilot AI balanced review requested due to automatic review settings September 15, 2026 15:36
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

The caller matches 2026.x and correctly invokes the centralized workflow.

Pull request overview

Adds the centralized PR milestone policy workflow to the 2.4 branch, matching 2026.x.

Changes:

  • Calls the shared PR policy workflow.
  • Rechecks policy when milestones or labels change.
  • Prevents overlapping runs per pull request.
File summaries
File Description
.github/workflows/pr-policy.yml Defines the thin reusable-workflow caller.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@berfinyuksel
berfinyuksel merged commit 290c5c8 into 2.4 Sep 16, 2026
18 of 19 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Skip Milestone Check Exempts this PR from the mandatory milestone requirement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants