Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
|
Superseded by existing dependency refresh PR #12863, which has been updated to include the TiDB Lightning fix from pingcap/tidb#71497. |
What problem does this PR solve?
Issue Number: ref pingcap/tidb#71496
DM import-into uses TiDB Lightning through
github.com/pingcap/tidb. The Lightning fix for reusing an existing downstream table after a CREATE TABLE execution error has been merged in TiDB, but the current TiFlow dependency still points to an older TiDB revision and does not contain the fix.What is changed and how it works?
Upgrade the TiDB module and its parser submodule to the TiDB revision containing the Lightning fix:
github.com/pingcap/tidb→v1.1.0-beta.0.20260923092734-13103a00793agithub.com/pingcap/tidb/pkg/parser→v0.0.0-20260923082834-1869807c5fdbThe dependency update also brings the compatible
client-goandtipbrevisions required by the new TiDB module. No DM business logic changes are needed; import-into will use the fixed Lightning implementation after rebuilding DM.Check List
Tests
go test ./dm/loader ./dm/checker ./dm/pkg/cancelcauseQuestions
Will it cause performance regression or break compatibility?
No. This only updates the TiDB/Lightning dependency used by DM.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note
Summary by CodeRabbit