Skip to content

dm: upgrade TiDB dependencies for import-into table reuse - #12872

Closed
GMHDBJD wants to merge 1 commit into
pingcap:masterfrom
GMHDBJD:update-tidb-deps-for-lightning-fix
Closed

GMHDBJD wants to merge 1 commit into
pingcap:masterfrom
GMHDBJD:update-tidb-deps-for-lightning-fix

Conversation

@GMHDBJD

@GMHDBJD GMHDBJD commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref pingcap/tidb#71496

DM import-into uses TiDB Lightning through github.com/pingcap/tidb. The Lightning fix for reusing an existing downstream table after a CREATE TABLE execution error has been merged in TiDB, but the current TiFlow dependency still points to an older TiDB revision and does not contain the fix.

What is changed and how it works?

Upgrade the TiDB module and its parser submodule to the TiDB revision containing the Lightning fix:

  • github.com/pingcap/tidb → v1.1.0-beta.0.20260923092734-13103a00793a
  • github.com/pingcap/tidb/pkg/parser → v0.0.0-20260923082834-1869807c5fdb

The dependency update also brings the compatible client-go and tipb revisions required by the new TiDB module. No DM business logic changes are needed; import-into will use the fixed Lightning implementation after rebuilding DM.

Check List

Tests

  • Unit tests: go test ./dm/loader ./dm/checker ./dm/pkg/cancelcause

Questions

Will it cause performance regression or break compatibility?

No. This only updates the TiDB/Lightning dependency used by DM.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

None

Summary by CodeRabbit

  • Chores
    • Updated internal component versions to incorporate dependency maintenance changes.
    • No user-facing features or behavior changes were introduced.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Sep 23, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zwj-coder for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 52240041-a0e1-4fa1-8b39-1ec82d133465

📥 Commits

Reviewing files that changed from the base of the PR and between 20f7694 and 8806c97.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod
 ______________________________________________
< Preventing the Y2K bug from happening again. >
 ----------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 23, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@GMHDBJD

GMHDBJD commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by existing dependency refresh PR #12863, which has been updated to include the TiDB Lightning fix from pingcap/tidb#71497.

@GMHDBJD GMHDBJD closed this Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant