Skip to content

release: bump version to v1.17.1 - #2739

Merged
kaaaaaaang merged 1 commit into
pingcap:masterfrom
ekexium:release/prepare-v1.17.1
Sep 8, 2026
Merged

release: bump version to v1.17.1#2739
kaaaaaaang merged 1 commit into
pingcap:masterfrom
ekexium:release/prepare-v1.17.1

Conversation

@ekexium

@ekexium ekexium commented Sep 8, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Prepare TiUP v1.17.1 with all four changes merged since v1.17.0: #2732, #2734, #2737, and #2738.

What is changed and how it works?

  • Bump the built-in version from 1.17.0 to 1.17.1.
  • Add changelog entries for Grafana VictoriaMetrics datasource replacement, monitoring on dedicated TiDB Dashboard hosts, shared exporter preservation during destroy, and concurrent TLS CA distribution.

The release-1.17 branch needs the four fixes and this version/changelog commit before publication. The Bookworm CI updates in #2738 are included in the release scope.

Check List

Tests:

  • make tiup cluster lint
  • go test ./pkg/version ./pkg/cluster/operation ./pkg/cluster/task ./pkg/cluster/spec
  • Built TiUP and cluster binaries report 1.17.1.

Related changes:

  • Need to cherry-pick to the release branch.

Release notes:

NONE

Summary by CodeRabbit

  • Bug Fixes

    • Fixed Grafana dashboard data source replacement when using VictoriaMetrics.
    • Restored node_exporter metrics collection on dedicated TiDB Dashboard hosts.
    • Preserved shared exporter directories and systemd units when destroying clusters with exporter retention enabled.
    • Prevented concurrent TLS certificate distribution from deploying empty CA certificates and blocking component startup.
  • Release

    • Updated the release version to 1.17.1.

Copilot AI lite review requested due to automatic review settings September 8, 2026 08:13
@ti-chi-bot

ti-chi-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
ti-chi-bot Bot requested review from kaaaaaaang and nexustar September 8, 2026 08:13
@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 8, 2026
@codecov-commenter

codecov-commenter commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.48%. Comparing base (c00f987) to head (f965165).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2739   +/-   ##
=======================================
  Coverage   38.48%   38.48%           
=======================================
  Files         426      426           
  Lines       47373    47373           
=======================================
  Hits        18230    18230           
  Misses      26717    26717           
  Partials     2426     2426           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are limited to a straightforward version bump and a well-formed changelog entry consistent with existing formatting.

Pull request overview

Prepares the TiUP v1.17.1 release by updating the built-in version constants and adding a corresponding changelog section that summarizes the four fixes included since v1.17.0 (#2732, #2734, #2737, #2738).

Changes:

  • Bump TiUP patch version from 1.17.0 to 1.17.1.
  • Add a new 1.17.1 changelog entry dated 2026-09-08 covering the four included fixes.
File summaries
File Description
pkg/version/version.go Updates patch version constant to report 1.17.1 in built binaries.
CHANGELOG.md Adds the 1.17.1 release notes section summarizing included fixes.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 846ddf01-d2aa-43e8-ae51-98f88d125983

📥 Commits

Reviewing files that changed from the base of the PR and between c00f987 and f965165.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • pkg/version/version.go

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The patch updates TiUP to version 1.17.1 and adds a changelog entry dated 2026-09-08. The entry lists four tiup-cluster fixes.

Changes

Release metadata

Layer / File(s) Summary
Version and changelog update
pkg/version/version.go, CHANGELOG.md
The patch version changes from 0 to 1. The changelog adds the 1.17.1 release entry and lists four tiup-cluster fixes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f9651

This release metadata change updates TiUP to report version 1.17.1 and documents the included fixes. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary change: bumping TiUP to version 1.17.1.
Description check ✅ Passed The description explains the release purpose, lists the included fixes, records validation steps, identifies the release-branch cherry-pick, and includes the release-note block. It omits some optional…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the version line
The changelog lists fixes in time
Patch one hops into view
Four fixes join the review
The release burrow shines fine

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the lgtm label Sep 8, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

[LGTM Timeline notifier]

Timeline:

  • 2026-09-08 08:41:39.303197001 +0000 UTC m=+1787134.474291111: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
kaaaaaaang merged commit db3e7fe into pingcap:master Sep 8, 2026
6 of 7 checks passed
@ekexium ekexium mentioned this pull request Sep 8, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants