You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Bug]: #24850 reverses #24560: re-checks can no longer continue the same reviewer #24877
A parent agent delegates a review with delegate_task; the reviewer returns a must-fix finding and the author fixes it.
The parent needs that same reviewer to re-check the fix.
Expected behavior
As in #24560 (which fixed #19821): independent review rounds start a fresh delegate_task, while a same-scope re-check that needs the reviewer's own context continues the reviewer with t3_thread_send on its childThreadId. t3_thread_send still supports this path: a follow-up to a completed child starts a new tracked task, returns its taskId, and notifies the parent.
Every new delegate review or re-check is a new delegate_task (brief, findings, objections), never a t3_thread_send.
and added tests that assert it (CodexDeveloperInstructions.test.ts, McpHttpServer.test.ts). So every re-check now has to go to a fresh reviewer, which re-reads the whole change and loses the context it used to raise the findings it is checking, plus the parent's prompt cache for that child. This reverses #24560 one day after it merged.
We agree with the other half of the same line ("Fix small review findings yourself; start no delegate for them"): skipping re-checks for small findings is a good change. This report is only about how a re-check that is still needed reaches the reviewer.
Could the guidance keep the #24560 distinction, or make this configurable? If agents were misusing t3_thread_send for independent reviews, keeping the distinction seems a narrower fix than banning the path.
Activity