Skip to content

Fix TWCC length overflow - #236

Merged
JoTurk merged 1 commit into
mainfrom
jo/fix-twcc-overflow
Oct 21, 2026
Merged

JoTurk merged 1 commit into
mainfrom
jo/fix-twcc-overflow

Conversation

@JoTurk

@JoTurk JoTurk commented Oct 21, 2026

Copy link
Copy Markdown
Member

Turns out Gosec's G115 linter was right, we should visit all the "nolint:gosec // G115"

Discovered by Anthropic's OSS Scanner (ANT-2026-WZBN6GIK). pion/webrtc#3641

@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.65%. Comparing base (09df03a) to head (a39ade4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   84.62%   84.65%   +0.02%     
==========================================
  Files          22       22              
  Lines        1665     1668       +3     
==========================================
+ Hits         1409     1412       +3     
  Misses        256      256              
Flag Coverage Δ
go 84.65% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoTurk

JoTurk commented Oct 21, 2026

Copy link
Copy Markdown
Member Author

Will mark Len() as deprecated.

Discovered by Anthropic's OSS Scanner (ANT-2026-WZBN6GIK).
Refs: pion/webrtc#3641
@JoTurk
JoTurk force-pushed the jo/fix-twcc-overflow branch from 0813caf to a39ade4 Compare October 21, 2026 01:13
@JoTurk
JoTurk merged commit a39ade4 into main Oct 21, 2026
19 checks passed
@JoTurk
JoTurk deleted the jo/fix-twcc-overflow branch October 21, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant