Skip to content

Zero RTP padding when marshaling into reused buffers - #379

Merged
JoTurk merged 1 commit into
mainfrom
jo/zero-padding
Oct 20, 2026
Merged

JoTurk merged 1 commit into
mainfrom
jo/zero-padding

Conversation

@JoTurk

@JoTurk JoTurk commented Oct 20, 2026

Copy link
Copy Markdown
Member

Description

Initialize padding bytes in the shared marshalling helper so Packet.MarshalTo and MarshalPacketTo cannot expose stale buffer contents.

Reference issue

Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-YQVAINZJ.

https://github.com/pion/webrtc/issues/3642

Initialize padding bytes in the shared marshalling
helper so Packet.MarshalTo and MarshalPacketTo
cannot expose stale buffer contents.

Discovered by Anthropic's OSS Scanner,
as vulnerability ANT-2026-YQVAINZJ.

https://github.com/pion/webrtc/issues/3642
@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.14%. Comparing base (e24c716) to head (f34b779).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   88.14%   88.14%           
=======================================
  Files          28       28           
  Lines        3171     3172    +1     
=======================================
+ Hits         2795     2796    +1     
  Misses        376      376           
Flag Coverage Δ
go 88.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoTurk
JoTurk merged commit f34b779 into main Oct 20, 2026
19 checks passed
@JoTurk
JoTurk deleted the jo/zero-padding branch October 20, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant