Skip to content

docs: add Netlify configuration for docs hosting migration - #6930

Merged
khanhtc1202 merged 8 commits into
pipe-cd:masterfrom
harshitghagre:migrate-docs-to-netlify
Aug 4, 2026
Merged

khanhtc1202 merged 8 commits into
pipe-cd:masterfrom
harshitghagre:migrate-docs-to-netlify

Conversation

@harshitghagre

Copy link
Copy Markdown
Member

What this PR does:

Why we need it:

Which issue(s) this PR fixes:

Fixes #6801

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@Ayushmore1214 Ayushmore1214 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshitghagre can we get some screenshots of this working ? I'm having some issue with it, I don't if its my env or the your code can you drop some outputs of this running, thanks!

@harshitghagre

Copy link
Copy Markdown
Member Author

@harshitghagre can we get some screenshots of this working ? I'm having some issue with it, I don't if its my env or the your code can you drop some outputs of this running, thanks!

thanks for review @Ayushmore1214 , you can test on this url https://pipecd-docs.netlify.app/

Comment thread hack/gen-release-docs.sh

@khanhtc1202 khanhtc1202 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the testing link, it looks great. I left one comment on script update.
Also, why was the site on netlify doesn't contain the docs for v0.56.x?

Comment thread docs/README.md Outdated
@harshitghagre

Copy link
Copy Markdown
Member Author

Checked the testing link, it looks great. I left one comment on script update. Also, why was the site on netlify doesn't contain the docs for v0.56.x?

It was misssing because the netlify build got timeout due to large page size, now i've increased build timeout. You can check on this url https://pipecd-docs.netlify.app/docs-v0.57.x/

@rahulshendre rahulshendre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @harshitghagre.
The DCO check is currently failing, please sign off your commit so the check passes

@mohammedfirdouss

Copy link
Copy Markdown
Contributor

@rahulshendre please review

@rahulshendre

Copy link
Copy Markdown
Contributor

Thanks for the nudge @mohammedfirdouss : )
One small nit, the netlify.toml redirect points to docs-v0.57.x, but #6480 made v1 the default.
Ideally this should point to v1.0.x instead
@harshitghagre please make the changes

Signed-off-by: harshitghagre <harshitghagre183@gmail.com>
@harshitghagre
harshitghagre force-pushed the migrate-docs-to-netlify branch from 4f5a7d1 to 81acc05 Compare June 29, 2026 07:08
@mohammedfirdouss

mohammedfirdouss commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

next time, @harshitghagre update the branch to match the base.

@rahulshendre pinging for your review.

@harshitghagre

Copy link
Copy Markdown
Member Author

next time, @harshitghagre update the branch to match the base.

@rahulshendre pinging for your review.

got it, thanks!

rahulshendre
rahulshendre previously approved these changes Jun 30, 2026

@rahulshendre rahulshendre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @harshitghagre

@khanhtc1202, what about the account/ DNS 👀

@rahulshendre

Copy link
Copy Markdown
Contributor

@harshitghagre, please resolve the conflicts

Signed-off-by: Harshit Ghagre <117425012+harshitghagre@users.noreply.github.com>
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.13%. Comparing base (83568d8) to head (6583812).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6930       +/-   ##
===========================================
+ Coverage   29.35%   48.13%   +18.78%     
===========================================
  Files         601       90      -511     
  Lines       64328     8671    -55657     
===========================================
- Hits        18885     4174    -14711     
+ Misses      43975     4206    -39769     
+ Partials     1468      291     -1177     
Flag Coverage Δ
. ?
.-pkg-app-pipedv1-plugin-analysis ?
.-pkg-app-pipedv1-plugin-ecs ?
.-pkg-app-pipedv1-plugin-kubernetes 58.39% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster ?
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.46% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 33.04% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 52.71% <ø> (ø)
.-pkg-plugin-sdk 50.34% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.51% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khanhtc1202

khanhtc1202 commented Aug 4, 2026

Copy link
Copy Markdown
Member

@harshitghagre Thanks for this contribution, I waited for this 🙌
Just to confirm, after this being merged, what we need to activate this version of the website as the pipecd official website, is to update DNS to point pipecd.dev to https://pipecd-docs.netlify.app/, isn't it?
Otherwise, it's a LGTM 👍
cc @rahulshendre @mohammedfirdouss @eeshaanSA

@khanhtc1202

Copy link
Copy Markdown
Member

@harshitghagre Thanks for this contribution, I waited for this 🙌 Just to confirm, after this being merged, what we need to activate this version of the website as the pipecd official website, is to update DNS to point pipecd.dev to https://pipecd-docs.netlify.app/, isn't it? Otherwise, it's a LGTM 👍 cc @rahulshendre @mohammedfirdouss @eeshaanSA

Never mind, I think I will self-create/connect the Netlify app to the pipe-cd/pipecd repo (since, as a CNCF project, we have some benefit from Netlify that can be active under my GitHub account), but let me do that after we merge this PR. I will also update the DNS to route pipecd.dev to the Netlify app later.

@khanhtc1202 khanhtc1202 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rahulshendre rahulshendre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@harshitghagre

Copy link
Copy Markdown
Member Author

@harshitghagre Thanks for this contribution, I waited for this 🙌 Just to confirm, after this being merged, what we need to activate this version of the website as the pipecd official website, is to update DNS to point pipecd.dev to https://pipecd-docs.netlify.app/, isn't it? Otherwise, it's a LGTM 👍 cc @rahulshendre @mohammedfirdouss @eeshaanSA

Thanks @khanhtc1202! We can use the URL from the PipeCD Netlify account later. The current URL, https://pipecd-docs.netlify.app/, is only for testing.

@khanhtc1202
khanhtc1202 merged commit ce45ba0 into pipe-cd:master Aug 4, 2026
60 checks passed
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing to PipeCD, @harshitghagre! The changes in this pull request will be part of the upcoming release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move PipeCD docs hosting to Netlify

5 participants