Repository navigation
fix(test): 🐛 pause the collector while an allocation gate measures - #369
Merged
Merged
Conversation
The Volume commit gate failed on macOS at 252,064 bytes per run against a ceiling of 252,032. One commit allocates about 252 KB, so the 100 commits of a measurement trigger several garbage collections. Each collection empties the sync.Pool caches. The commits then allocate again the objects that those caches held, and the amount depends on the timing of each collection. - The gates now pause the collector during each measurement. A collection still runs before each measurement. - With the collector paused, the commit gate measures 135 allocations in all 150 runs, so this change lowers its allocation ceiling from 136 to 135. Its byte ceiling stays at 252,032. - In a few runs, the read gates measure two more allocations than usual, and pausing the collector does not remove that difference. Their ceilings already cover both counts and remain unchanged. - docs/BENCHMARKS.md explains the pause and lists the new ceiling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
justapithecus
changed the title
justapithecus
marked this pull request as ready for review
November 6, 2026 22:29
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Volume commit gate failed on macOS at 252,064 bytes per run against a ceiling of 252,032. One commit allocates about 252 KB, so the 100 commits of a measurement trigger several garbage collections, and each collection empties the sync.Pool caches that the commits reuse. The gates now pause the collector while they measure, so the timing of a collection no longer moves a figure.
Highlights
Test plan
No-Issue: macOS gate failure on #368
🤖 Generated with Claude Code