Repository navigation
Fix OpenAI reasoning caps and Gemini transparent images - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAI agents now send
max_completion_tokensby default, so a token cap works with reasoning models such aso3. Explicitmax_tokensandmax_completion_tokenssettings still take precedence, and tool follow-ups continue to omit tools.Gemini image turns now use PNG with the matching MIME type. Normalizing to RGBA preserves transparency and supports image modes such as CMYK that PNG cannot encode directly.
Regression tests exercise
Agent.chat()andAgent.tool_call()through the actual provider SDKs with mocked HTTP transports, inspecting request bodies and decoded image pixels. No live provider calls are required.Validation:
git diff --checkpassed.