Repository navigation
Allow tortoise-test3 for --place/--gm-clear/--gm-instance-data; never lease slot 3 there - #440
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets the turtle-agent test-server tools work on tortoise-test3 too, and keeps slot 3 there off limits.
placeServersgets tortoise-test3. It gates raid-walk--place/--gm-clear/--gm-instance-data, plan-scout--liveand the GM-kill authorization; the GM kill is still bound to the slots file's configuredworld_addr.neverLeasablegetstortoise-test3/3, so slot 3 on test3 is never leased, also not by the any-free-slot path. New test:TestTortoiseTest3Slot3IsAlwaysReserved.Tortoise Trials runs on tortoise-test3 and used a local build with this change. It was never merged, so binaries built from dev refused test3.
Tests:
vm-test tapasses (full suite). Reviews: Codex adversarial approve; cold review (its slot-3 finding is fixed here).