Support PEP-639 style License-Expression fields - #322
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Perhaps we should generate this wheel at test time, just to prove there's nothing weird going on in this plugin (a la CVE-2024-3094)? It'd be pretty straightforward too, given that we could build it with arcat. If you want to save keystrokes and a bit of complexity, fakepkg/__init__.py isn't necessary - a wheel consisting only of metadata is legit (and occasionally seen in the wild as a way of implementing virtual packages).
Member
Author
There was a problem hiding this comment.
That's fair - just call me Jia Ebden...
(I've left the __init__.py in, it doesn't make it any harder to construct)
peterebden
force-pushed
the
peter/license-expression
branch
from
September 15, 2026 11:58
6752779 to
ed83e95
Compare
chrisnovakovic
approved these changes
Sep 15, 2026
| repo = repo or CONFIG.PYTHON.DEFAULT_PIP_REPO | ||
| if repo: | ||
| if looks_like_build_label(repo): # Looks like a build label, not a URL. | ||
| repo_flag = f'-f %(location {repo})' |
Member
Author
There was a problem hiding this comment.
Amazingly nobody noticed...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are superseding the old freeform text
License:fields. There are some packages in the wild that have this and notLicenceany more, presumably that will increase over time.https://peps.python.org/pep-0639/
These are SPDX expressions. Please doesn't parse those for now, but it can crudely support them by simply entering each expression as a licence. In the future when we add the ability to parse them, this should just work.
Also fixed a couple of existing bugs about how the
repoargument got used inpip_library.