Add caching to GHA - #326
Merged
Merged
Conversation
| ./pleasew -o "plugin.python.defaultinterpreter:$_external_interpreter" test --profile ci --keep_going --log_file plz-out/log/test-external_interpreter.log ${{ inputs.test_targets }} | ||
| echo "*** Running tests using in-repo Python interpreter: $_in_repo_interpreter" | ||
| ./pleasew -o "plugin.python.defaultinterpreter:$_in_repo_interpreter" test --rerun --keep_going --log_file plz-out/log/test-in_repo_interpreter.log ${{ inputs.test_targets }} | ||
| ./pleasew -o "plugin.python.defaultinterpreter:$_in_repo_interpreter" test --profile ci --keep_going --log_file plz-out/log/test-in_repo_interpreter.log ${{ inputs.test_targets }} |
Contributor
There was a problem hiding this comment.
If --rerun is removed here, is there a risk that the tests always pass on this invocation (because they passed on the previous one)? I think changing the value of CONFIG.PYTHON.DEFAULT_INTERPRETER ought to invalidate the cached results, but there must have been a reason I added --rerun here...
Member
Author
There was a problem hiding this comment.
Yeah I wasn't sure what it was for - we shouldn't need that ideally. Changing the interpreter will be an input to the test so it would force it to rerun anyway
chrisnovakovic
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm seeing a lot of random download failures in the tests. Thinking this is because we have a large fan-out of platforms / versions and they all re-download a bunch of Github artifacts, hitting rate limiting.
It seems like it might help if we cache those things. This is keyed on the Please version (for arcat) and the plugin and third-party versions, although it has a 'soft' restore key to avoid full rebuilds when we change something.