You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs: track bun lint compatibility until a stable release - #60
Adds docs/research/bun-lint-compatibility.md. It tracks how @pleaseai/eslint-config behaves under Bun's built-in bun lint until bun lint ships in a stable Bun release.
Baseline from canary 1.4.4-canary.1+5f5799ed1: 103 / 253 native / JS rules as-is, and 129 / 227 with ts → @typescript-eslint. Results match ESLint, with no speedup at this repo's size.
Findings: only part of eslint-plugin-n runs natively (none of antfu's 8 node/* rules); after the rename, existing ts/… disable comments become errors; a package.jsonlint script shadows the built-in; and --doctor wrongly suggests removing @pleaseai/eslint-config.
No breaking change, or a BREAKING CHANGE: note is included
Summary by cubic
Adds docs/research/bun-lint-compatibility.md, tracking how @pleaseai/eslint-config behaves under Bun's canary bun lint until it ships in a stable release, plus comparison baselines for @antfu/eslint-config 9.5.1 and eslint-config-xo 6.0.0. Baseline from 1.4.4-canary.1+5f5799ed1: 103/253 native rules as-is, 129/227 after renaming ts → @typescript-eslint, matching ESLint results with no speedup at this repo size. Re-measured on the oven-sh/bun#45595 PR build, which adds native JSON and Markdown rules.
Findings
Only part of eslint-plugin-n runs natively; none of antfu's 8 enabled node/* rules do.
After the ts rename, existing eslint-disablets/... comments become errors.
A package.jsonlint script shadows the built-in; --no-script is documented but missing from the tested canary.
--doctor wrongly suggests removing @pleaseai/eslint-config even though eslint.config.ts imports it.
eslint-config-xo silently misses 16 findings on a whole project because Bun gives types only to native rules.
With #45595, Markdown rules run natively for antfu-based configs; JSON still goes to ESLint because antfu uses eslint-plugin-jsonc.
Includes a watch list and a manual re-check procedure to run against future stable releases.
Written for commit f18ddc4. Summary will update on new commits.
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer TIP This summary will be updated as you push new changes.
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new documentation file, docs/research/bun-lint-compatibility.md, to track the compatibility of @pleaseai/eslint-config with Bun's built-in bun lint command. The documentation details current benchmark results, findings, a watch list, and a re-check procedure. Feedback on the pull request suggests improving the re-check bash script by parameterizing the platform architecture instead of hardcoding Linux-specific values, ensuring better usability for developers on macOS or other systems.
The reason will be displayed to describe this comment to others. Learn more.
[MEDIUM] Hardcoded Linux-specific platform in re-check procedure
Problem: The re-check procedure hardcodes the Linux x64 binary (bun-linux-x64.zip and the bun-linux-x64 directory), which will fail for developers running macOS or other architectures.
Rationale: This style guide (Section 1 - Maintainability: Can future engineers read and modify it easily?).
Suggestion: Define a PLATFORM variable at the beginning of the script block to make it easy for developers on macOS or other platforms to adjust the target binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
docs/research/bun-lint-compatibility.md. It tracks how@pleaseai/eslint-configbehaves under Bun's built-inbun lintuntilbun lintships in a stable Bun release.1.4.4-canary.1+5f5799ed1: 103 / 253 native / JS rules as-is, and 129 / 227 withts→@typescript-eslint. Results match ESLint, with no speedup at this repo's size.eslint-plugin-nruns natively (none of antfu's 8node/*rules); after the rename, existingts/…disable comments become errors; apackage.jsonlintscript shadows the built-in; and--doctorwrongly suggests removing@pleaseai/eslint-config.--no-script, native JSON/Markdown, bun lint: overrides[].files extglob patterns silently never match with an oxlint config, but match with an ESLint config oven-sh/bun#45470, TypeScript 7 vs. typescript-eslint) and a manual re-check procedure.Docs only. No package or config changes.
Related issue
Refs #56 (summary posted in #56 (comment))
Checklist
bun run build)bun run lint)BREAKING CHANGE:note is includedSummary by cubic
Adds
docs/research/bun-lint-compatibility.md, tracking how@pleaseai/eslint-configbehaves under Bun's canarybun lintuntil it ships in a stable release, plus comparison baselines for@antfu/eslint-config9.5.1 andeslint-config-xo6.0.0. Baseline from1.4.4-canary.1+5f5799ed1: 103/253 native rules as-is, 129/227 after renamingts→@typescript-eslint, matching ESLint results with no speedup at this repo size. Re-measured on the oven-sh/bun#45595 PR build, which adds native JSON and Markdown rules.Findings
eslint-plugin-nruns natively; none of antfu's 8 enablednode/*rules do.tsrename, existingeslint-disablets/...comments become errors.package.jsonlintscript shadows the built-in;--no-scriptis documented but missing from the tested canary.--doctorwrongly suggests removing@pleaseai/eslint-configeven thougheslint.config.tsimports it.eslint-config-xosilently misses 16 findings on a whole project because Bun gives types only to native rules.eslint-plugin-jsonc.Written for commit f18ddc4. Summary will update on new commits.