Repository navigation
coll/csel: fix clang/icx build; fix clang testsuite warnings - #8127
Merged
Merged
Conversation
hzhou-muse
force-pushed
the
csel-default-decl
branch
from
November 9, 2026 03:04
48b28a9 to
798655b
Compare
Wrap the default case in validate_defined_conditions in a block, so cond_name is declared inside it rather than directly after the label. Previously the declaration followed the default: label, which is not valid before C23 and broke the clang and Intel oneAPI builds. Model: Claude Opus 5.5
hzhou-muse
force-pushed
the
csel-default-decl
branch
from
November 9, 2026 03:05
798655b to
89e24ec
Compare
Contributor
Author
|
test:mpich/custom |
hzhou
approved these changes
Nov 9, 2026
Check the count returned by MPI_T_pvar_handle_alloc with ==. Previously the asserts assigned 1 to count, so they always passed, and clang warned about it. Model: Claude Opus 5.5
End test_thread in the threadcomm tests with a return, as the other thread tests do. Previously they fell off the end of a non-void function, which clang warns about. Model: Claude Opus 5.5
Let the memtype_str switch in struct_{pack,unpack}_mpi_bottom fall
through to the numeric format with a default case. Previously clang
warned that the remaining memory types were not handled in the switch.
Model: Claude Opus 5.5
hzhou-muse
changed the title
Contributor
Author
|
test:mpich/custom |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Since 5de2fd2,
validate_defined_conditionsincsel_validation.cdeclaresconst char *cond_name;directly after adefault:label. Before C23 that is not valid C, so clang and Intel oneAPI reject it (error: expected expression). All clang and intel-oneapi cells ofmpich-main-ch4-ucxfail to build (e.g. builds 1244 and 1248).This PR wraps the default case in a block, so the declaration is local to it.
It also fixes the warnings clang reports when building the testsuite:
mpi_t/mpit_test2:assert(count = 1)assigned instead of comparingthreadcommtests: thread functions fell off the end without a returndatatype/struct_{pack,unpack}_mpi_bottom: switch inmemtype_strhad no default caseAuthor Checklist
Model: Claude Opus 5.5