Conversation
The declared MSRV (1.75) could not build the locked dependencies: Cargo.lock is v4, toml 1.1 / serde_spanned need edition 2024 (1.85), and regress 0.11 uses let-chains (1.88). The MSRV job still passed because rust-toolchain.toml pins stable, which overrides the toolchain the job installs. - rust-version = "1.88" (1.87 fails, 1.88 builds and passes all tests) - MSRV job: install via `dtolnay/rust-toolchain@master` + `toolchain` input (Dependabot kept "upgrading" the `@1.75` ref, see #204) and run `cargo +1.88 test --locked` so rust-toolchain.toml cannot override it - README badge and CHANGELOG updated - Promote clippy::trivially_copy_pass_by_ref to deny Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The declared MSRV (Rust 1.75) was not real. 1.75 cannot build
main:Cargo.lockis lockfile v4, which Cargo 1.75 can't read.toml1.1 andserde_spanned1.1 are edition 2024 (needs 1.85). Cargo 1.84 fails withfailed to download serde_spanned v1.1.1.regress0.11.1 uses let-chains (stable in 1.88) and doesn't declare arust-version. Rust 1.85 through 1.87 fail witherror[E0658]: `let` expressions in this position are unstable.The
MSRV (1.75)job still passed becauserust-toolchain.tomlpinsstable, which overrides the toolchain the job installs. So it was just a second stable build.Changes:
rust-version = "1.88". I checked locally: 1.87 fails to build, and 1.88 builds and passes the full test suite with--locked.dtolnay/rust-toolchain@masterwith atoolchain: "1.88"input, instead of the@1.75ref. Dependabot reads@1.xxas an action version; that is why chore: bump dtolnay/rust-toolchain from 1.75 to 1.120 #204 wants to "bump" it to@1.120. This PR makes chore: bump dtolnay/rust-toolchain from 1.75 to 1.120 #204 obsolete.cargo +1.88 test --locked. The+1.88overridesrust-toolchain.toml, and it now runs tests, not just a build.clippy::trivially_copy_pass_by_refis nowdeny(no existing violations).Branch protection on
mainhas no required checks, so renaming the job doesn't block anything.Test plan
cargo +1.88 test --lockedpasses (112 lib, 31 bin, 17 cli, 11 integration)cargo +1.87 build --lockedfails (confirms 1.88 is the real floor)cargo clippy --all-targets --locked -- -D warningspasses (clippy's MSRV-aware lints now use 1.88)cargo fmt -- --checkpassesMSRV (1.88)job is green and its log showsrustc 1.88.0runningcargo +1.88 test --locked🤖 Generated with Claude Code