feat: add enemy escort night battle engagement check - #136
Merged
Conversation
KochiyaOcean
added a commit
that referenced
this pull request
Aug 20, 2026
Address review findings on #136. The escort night engagement warning stayed visible on the post-battle result panel, advising an engagement that is no longer possible, and it only appeared there when there was no drop (DropInfo otherwise replaces battleInfo). Add isBattleEnded to BattleDisplayState, set on the battle result packet and reset on port and every api_req_map/*, and require it to be false for escortNight. Also make hasEnteredNightBattle optional in BattleViewAreaProps to match its siblings, so the default value is no longer dead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
增加了对二队状态的判定，提示用户当前状态下进入夜战是否有接二队的风险