Enforce panic catching in the Oak LSP - #1406
Open
lionel- wants to merge 7 commits into
Open
Conversation
In case the future panics
lionel-
added this pull request to stack #1407
September 11, 2026 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1405.
This PR enforces good panic catching conventions for Salsa accesses.
All Salsa DB access now go through dedicated accessors that check whether a "panic boundary" (i.e. a catch site) is active on the stack. This ensures that new code/handlers in the Oak LSP are properly guarded against panics.
A clippy rule disallows bare panic catching. Instead the codebase must now use
crate::panic::catch_unwind()which declares a panic boundary.Add boundaries around Tokio tasks and processes.
Positron Release Notes
New Features
Bug Fixes