Pass through console document id from rstudioapi editor context - #1408
Open
juliasilge wants to merge 2 commits into
Open
Pass through console document id from rstudioapi editor context#1408juliasilge wants to merge 2 commits into
id from rstudioapi editor context#1408juliasilge wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rstudioapi::getActiveDocumentContext()via shim, similar to other rstudioapi shims positron#15571idfrom rstudioapi editor context positron#16063This set of PRs makes
rstudioapicontext aware of the console. The two PRs can merge in either order, because R reads the raw JSON reply instead of the generated struct.This change adds an optional
idfield to the editor context from.rs.api.getSourceEditorContext().rstudioapi::getActiveDocumentContext()calls this function, so it gets the new field too. When the context is the console, the frontend setsidto"#console". Editor contexts do not yet include this field.Positron Release Notes
New Features
rstudioapi::getActiveDocumentContext()andgetSourceEditorContext()now return a documentid. This is"#console"when the context is the console (Supportrstudioapi::getActiveDocumentContext()via shim, similar to other rstudioapi shims positron#15571).Bug Fixes