Repository navigation
fix: Use Pyodide's anyio and sniffio instead of stale lockfile copies - #271
Merged
Merged
Conversation
Contributor
Coverage report
Test suite run success342 tests passing in 20 suites. Report generated by 🧪jest coverage report action from a2d6400 |
schloerke
force-pushed
the
schloerke/use-pyodide-anyio
branch
from
November 2, 2026 21:36
9b4c5d1 to
a2d6400
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python apps have been getting anyio 4.4.0 instead of the 4.9.0 that Pyodide 0.27.7 ships.
anyio was never pinned. It isn't in
shinylive_requirements.json; it enteredshinylive_lock.jsonas a dependency of starlette in 896a740 (posit-dev/shinylive#161, 2024-07-24), when Pyodide (0.26.x) didn't ship it. Pyodide added anyio and sniffio later, butmake allonly refreshes the local packages in the lockfile (update_lockfile_local), so the PyPI entries never moved. Lockfile entries replace Pyodide's, so the old anyio has replaced the newer one since then.This removes the
anyioandsniffioentries fromshinylive_lock.json, which is what a fullmake update_packages_lockwould do, since it skips dependencies Pyodide already ships. Pyodide's anyio 4.9.0 meets starlette's>=3.4.0,<5. sniffio is the same version in both (1.3.1); it goes too because it was only there for anyio.make allwon't add them back, because_recurse_dependencies_lockfileskips packages in Pyodide's lock.altair and narwhals also appear in both files, but the lockfile copies are newer than Pyodide's, so they are left alone.