Repository navigation
Conversation
schloerke
changed the title
…tyles.css A server NULL / None arrives as null, but the hook was typed T | undefined, so `x !== undefined` narrowed to T and crashed at runtime. Also export the stylesheet as @posit-dev/shinyreact/styles.css so TypeScript resolves the import through a *.css module declaration. Fixes #329
schloerke
force-pushed
the
schloerke/output-value-null
branch
from
November 9, 2026 21:40
5ca8966 to
4ec44cb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes posit-dev/shinyreact#329.
A server
NULL/Nonereaches the client asnull, butuseShinyOutputValue()was typedT | undefined. Code that checkedx !== undefinedpassed the type checker and then crashed at runtime. The return type is nowT | null | undefined.Also from the issue: the stylesheet is now exported as
@posit-dev/shinyreact/styles.csstoo. With the.cssname, TypeScript matches a*.cssmodule declaration (for examplevite/client), so nodeclare moduleis needed. The old./stylesexport stays.Note: the type change may make existing TypeScript callers handle
null. That is the point, but it can show up as new type errors on upgrade.