Repository navigation
fix(test): stabilize frpc cleanup and sync release history - #16
Merged
Merged
Conversation
CN059
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
The frpc controller tests deleted their temporary directory immediately after requesting asynchronous shutdown. CI exposed a race with the supervisor's directory cleanup, leaking an uncaught assertion into the next test. Add a shutdown-completion wait and use it before test directory deletion.
Also integrate the previous main release merge commit so dev meets the strict up-to-date requirement for release PR #15. The history merge itself makes no file changes.
Validation
Local Android build, application unit tests and lint; required CI checks must pass before merging.