test: fix npm stub on Windows - #248
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
angeloashmore
marked this pull request as ready for review
July 31, 2026 18:25
lihbr
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
Description
Windows CI times out on the
initandgen setuptests almost every run.Reason: The npm stub in
test/it.tsnever worked on Windows: it is a POSIX shell script with a shebang (Windows only executes.exe/.cmd/.bat), and the stub directory was prepended toPATHwith:instead of;. Tests therefore ran the realnpm install next@latestin a temp dir, which takes 30–180s on Windows runners and blows the 30s test timeout.Solution: Add an
npm.cmdstub next to the existing sh stub and usepath.delimiterfor thePATHprepend.Checklist
Preview
How to QA 1
Check that the
test windowsjobs pass without theinit/gen setuptimeouts.🤖 Generated with Claude Code
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩