Repository navigation
fix(release): generate a cask Homebrew 7 accepts - #388
Merged
Merged
Conversation
Two stanzas in the homebrew-release template no longer suit Homebrew 7:
- `verified:` on the url is accepted only as a no-op and prints a
deprecation warning on every install and upgrade.
- `depends_on macos: ">= 13.5"` fails to load: Homebrew 7 takes only a
release name there ("unknown or unsupported macOS version"). The cask
this workflow writes for v0.3.0 would have broken `brew install` for
everyone once the tap PR merged.
The url drops `verified:`, and the release context maps the major of
tauri.conf.json's minimumSystemVersion to Homebrew's release name (13.5
becomes :ventura, which Homebrew reads as 13.0 or later; the app's own
LSMinimumSystemVersion still refuses 13.0-13.4). An unknown major stops
the job instead of guessing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Homebrew 7 warns on every install and upgrade of the cask:
verified:comes from the template inhomebrew-release.yml, so fixing only the tap would bring it back with the next release. The tap's live cask is fixed in privacykey/homebrew-tap#23.While checking the template against Homebrew 7.0.8, I found a worse problem. The cask this workflow would write for v0.3.0 does not load at all:
Homebrew 7 accepts only a release name there. Once the v0.3.0 bump PR merged in the tap,
brew install --cask privacytrackerwould have failed for everyone.verified:. The url and homepage share a host, and Homebrew 7 ignores the parameter anyway.tauri.conf.json'sminimumSystemVersionto Homebrew's release name, using Homebrew 7's ownMacOSVersion::RELEASEStable. 13.5 becomes:ventura, which Homebrew reads as 13.0 or later. Homebrew can't express a point release, and the app's ownLSMinimumSystemVersionstill refuses 13.0 to 13.4 at launch. An unknown major stops the job with an error instead of guessing.How it was verified
All checks used Homebrew 7.0.8 on macOS, loading each cask with
Cask::CaskLoader::FromPathLoaderthroughbrew ruby. Homebrew 7'sbrew stylerefuses a cask outside a tap.verified:: loads with no warning; the url specs are identical ({user_agent: :default}).VERSION=0.3.0andMINIMUM_MACOS=13.5, it loads with no warning anddepends_on macos: :ventura. Before this change the same render raised the error above.caseblock, run on its own: 13.5 givesventura, 26.0 givestahoe, and 16.0 exits 1 with::error::.actionlinton the workflow: clean.No CHANGELOG entry. The warning goes away for users through the tap PR, and this change only stops the next release from bringing it back or shipping an unloadable cask.
Checklist
🤖 Generated with Claude Code