Skip to content

Fix restore races and update rustls before v0.3.0 - #394

Merged
AdamXweb merged 1 commit into
mainfrom
fix/prelaunch-readiness
Oct 16, 2026
Merged

AdamXweb merged 1 commit into
mainfrom
fix/prelaunch-readiness

Conversation

@adamXbot

Copy link
Copy Markdown
Collaborator

What and why

Backup restore could replace the database while Wayback, policy or import work was running, and a sync started during upload bypassed its early check. Both backends now reject restore before upload and immediately before replacement while registered asynchronous writers remain live. Rust checks under the same connection lock as the restore; detached tasks register before spawning. The Node rollback also protects worker commits, per-app requests and background writes. The legacy Node Wayback algorithm is unchanged.

Update only rustls from 0.23.45 to 0.23.46 in both shipping lockfiles and regenerate notices, resolving RUSTSEC-2026-0346 through -0349 without weakening cargo-audit. This follows AGENTS.md's narrow advisory-fix procedure.

How it was verified

  • Lint, typecheck, locale parity, route manifest and release metadata checks pass; production build succeeds.
  • Node: 1,163 passing tests, four live-network tests skipped by default. Rust core: 469 passing tests. macOS desktop without default features: 65 passing tests. Release suite: 30 passing tests.
  • New regressions cover work started during upload, every background mutex, live jobs after a mutex is cleared, overlapping/erroring writers, a real per-app policy fetch, and the Node history request's upload window. Failed restores preserve current data; retry succeeds once writers finish.
  • A rebuilt Rust server on disposable data returns 409 in both original reproductions: sync started during upload and a live Wayback job waiting on a persisted cooldown. The Wayback queue remains unchanged, with no archive.org traffic.
  • All three locked Cargo advisory checks report zero vulnerabilities. Existing backend replay fixtures remain unchanged.

Remaining release gates

This PR does not change GitHub administration settings. The authenticated account has push access but no administration access. An administrator must add the CODEOWNERS human owner AdamXweb as a required macos-signing reviewer, retain the v* tag restriction, and add e2e-rust from GitHub Actions to ruleset 17555639. The strict repository audit still fails those two checks and cannot verify the secret-scanning configuration with this account.

Review and merge only after current CI passes. Signed/notarized candidate verification and the human signing approval remain required before publication. No release was published or signing gate bypassed.

@adamXbot
adamXbot marked this pull request as ready for review October 16, 2026 02:09
@adamXbot
adamXbot requested a review from AdamXweb as a code owner October 16, 2026 02:09
@AdamXweb
AdamXweb merged commit e6243d9 into main Oct 16, 2026
21 checks passed
@AdamXweb
AdamXweb deleted the fix/prelaunch-readiness branch October 16, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants