Skip to content

fix(deps): clear the npm and RustSec advisories that fail CI's audit steps - #400

Open
adamXbot wants to merge 2 commits into
mainfrom
fix/dependency-audit-advisories
Open

adamXbot wants to merge 2 commits into
mainfrom
fix/dependency-audit-advisories

Conversation

@adamXbot

@adamXbot adamXbot commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

Why

quality fails at pnpm audit --prod and rust-check fails at cargo audit on every open PR, because both advisory databases are fetched fresh on each run. This clears both, so the stacked PRs pick up the fix when they rebase.

npm (pnpm audit --prod: 14 advisories, now 0)

Package From To Advisory Severity Fixed in
next 16.3.8 16.4.5 GHSA-2464-fhr4-w9xw critical 16.4.1
next GHSA-673q-mjm6-r5xr critical 16.4.1
next GHSA-p3m5-59mp-jv5r high 16.4.1
dompurify 3.4.16 3.4.17 GHSA-cg2g-xh64-v4q7 critical 3.4.17
dompurify GHSA-mrv2-3pqr-j5jr high 3.4.17
dompurify GHSA-c6gr-qvv4-5v3f low 3.4.17
undici 7.29.1 7.30.2 GHSA-xjj6-f33q-929c high 7.30.1
undici GHSA-4w7w-5xrc-9h26 high 7.30.1
undici GHSA-2m5v-pch6-74hx high 7.30.1
undici GHSA-qrxm-fqhp-jwvm high 7.30.1
undici GHSA-4qv8-2p9j-2685 moderate 7.30.1
undici GHSA-f72v-6w45-q472 moderate 7.30.1
undici GHSA-9fm3-97px-rjf6 moderate 7.30.1
undici GHSA-55wc-3pg8-jfw6 moderate 7.30.1

All three are direct dependencies, so no new override was needed. The minimumReleaseAgeExclude entry for undici@7.29.1 is removed because that version is no longer in the tree.

Rust (cargo audit: 2 in core/Cargo.lock and 7 in src-tauri/Cargo.lock, now 0)

Crate Advisory Lockfile Change
rustls-webpki RUSTSEC-2026-0382 core, src-tauri 0.103.15 to 0.103.16
webpki-roots RUSTSEC-2026-0381 core (1.0.9), src-tauri (1.0.8) to 1.0.11 (fixed in 1.0.10)
webpki-root-certs RUSTSEC-2026-0383 src-tauri 1.0.8 to 1.0.11 (fixed in 1.0.10)
zip RUSTSEC-2026-0367, -0368, -0369, -0429 src-tauri removed (see below)

Reviewer decision: zip is removed, not upgraded

Those four advisories are fixed only in zip 9, a major version above the 4.6.1 we had. tauri-plugin-updater first depends on zip 9 at 2.14.1, which needs tauri >= 2.12, so that route also moves Tauri, its runtime crates and the @tauri-apps npm packages a minor version, right before v0.3.0.

Instead, src-tauri/Cargo.toml turns off the plugin's optional zip feature:

  • On macOS the plugin's tar and flate2 dependencies are not optional, so the .app.tar.gz install path is unchanged. The zip crate was only ever a Windows dependency.
  • Only macOS builds ship, and update_guard.rs already refuses installs on other platforms.
  • The lock diff is just zip, arbitrary and derive_arbitrary going away.

If a Windows or Linux build ever ships, the feature has to come back, on plugin 2.14.1 or later. A comment beside the dependency says so.

Exposure: the next and undici advisories apply only to the Docker image's Node rollback (BACKEND=node) and development. The default Rust image and the desktop app serve a static build.

Container image (container-smoke's Trivy scan: 3 HIGH findings, all from the base image)

container-smoke is skipped while quality fails, so these only surfaced once the fixes above let it run.

Package From To Advisory Severity
musl, musl-utils 1.2.6-r2 1.2.6-r3 CVE-2026-107891 high
zlib 1.3.2-r0 1.3.2-r1 CVE-2026-85091 high

ALPINE_IMAGE moves from 3.24.2 to 3.24.4, pinned by digest. I read the package database out of that digest from the registry for amd64 and arm64, and both carry these versions. CI's scan is the first real run of Trivy against it.

The Node rollback base (node:24.20.0-alpine, BACKEND=node) still has musl 1.2.6-r2 and zlib 1.3.2-r0. container-smoke does not scan that image, so it does not affect this PR, but docker-publish.yml would refuse it on a release with backend: node.

Verified locally

  • pnpm audit --prod exits 0. cargo audit --file exits 0 for all three lockfiles.
  • tsc --noEmit, Biome (1056 files), i18n parity.
  • tests/app: 1163 passed, 0 failed, 4 skipped. tests/release: 30 passed.
  • cargo test --locked for core/ and src-tauri/ (macOS).
  • next build --webpack on 16.4.5 with generate-csp-hashes (38 static routes).
  • Playwright against next start: security-headers, loading-shell and zz-csp-integrity, 11 passed.

Not run locally: the full e2e suites, the Turbopack build CI uses (the local SSD setup forces webpack), a Linux compile of src-tauri without the feature (the plugin's Linux path is feature-gated; rust-check covers it), and a signed release build of the updater.

pnpm notices:rust regenerated both crate lists. lib/rust-crates.json did not change.

🤖 Generated with Claude Code

…steps

`pnpm audit --prod` and `cargo audit` fetch their databases fresh, so newly
published advisories turned every open PR red.

npm: next 16.3.8 -> 16.4.5, dompurify 3.4.16 -> 3.4.17, undici 7.29.1 ->
7.30.2. The minimumReleaseAgeExclude entry for undici 7.29.1 goes with it.

Rust: rustls-webpki 0.103.16 and webpki-roots 1.0.11 in core and src-tauri,
webpki-root-certs 1.0.11 in src-tauri. The four zip advisories are fixed only
in zip 9, which the updater plugin reaches only from 2.14.1 (needing tauri
>= 2.12), so the plugin's optional `zip` feature is turned off instead. That
crate was compiled only for Windows, and only macOS builds ship.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@adamXbot
adamXbot requested a review from AdamXweb as a code owner November 8, 2026 08:09
container-smoke's Trivy step fails the image on HIGH findings in Alpine
3.24.2's own packages: CVE-2026-107891 in musl and musl-utils 1.2.6-r2, and
CVE-2026-85091 in zlib 1.3.2-r0. The job was skipped while `quality` failed,
so the findings only surfaced once the audit fixes let it run.

Alpine 3.24.4 ships musl and musl-utils 1.2.6-r3 and zlib 1.3.2-r1 on both
image architectures, the versions Trivy names as fixed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@adamXbot adamXbot mentioned this pull request Nov 8, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant