Repository navigation
Conversation
…steps `pnpm audit --prod` and `cargo audit` fetch their databases fresh, so newly published advisories turned every open PR red. npm: next 16.3.8 -> 16.4.5, dompurify 3.4.16 -> 3.4.17, undici 7.29.1 -> 7.30.2. The minimumReleaseAgeExclude entry for undici 7.29.1 goes with it. Rust: rustls-webpki 0.103.16 and webpki-roots 1.0.11 in core and src-tauri, webpki-root-certs 1.0.11 in src-tauri. The four zip advisories are fixed only in zip 9, which the updater plugin reaches only from 2.14.1 (needing tauri >= 2.12), so the plugin's optional `zip` feature is turned off instead. That crate was compiled only for Windows, and only macOS builds ship. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
container-smoke's Trivy step fails the image on HIGH findings in Alpine 3.24.2's own packages: CVE-2026-107891 in musl and musl-utils 1.2.6-r2, and CVE-2026-85091 in zlib 1.3.2-r0. The job was skipped while `quality` failed, so the findings only surfaced once the audit fixes let it run. Alpine 3.24.4 ships musl and musl-utils 1.2.6-r3 and zlib 1.3.2-r1 on both image architectures, the versions Trivy names as fixed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
qualityfails atpnpm audit --prodandrust-checkfails atcargo auditon every open PR, because both advisory databases are fetched fresh on each run. This clears both, so the stacked PRs pick up the fix when they rebase.npm (
pnpm audit --prod: 14 advisories, now 0)All three are direct dependencies, so no new override was needed. The
minimumReleaseAgeExcludeentry forundici@7.29.1is removed because that version is no longer in the tree.Rust (
cargo audit: 2 incore/Cargo.lockand 7 insrc-tauri/Cargo.lock, now 0)Reviewer decision:
zipis removed, not upgradedThose four advisories are fixed only in zip 9, a major version above the 4.6.1 we had.
tauri-plugin-updaterfirst depends on zip 9 at 2.14.1, which needstauri >= 2.12, so that route also moves Tauri, its runtime crates and the@tauri-appsnpm packages a minor version, right before v0.3.0.Instead,
src-tauri/Cargo.tomlturns off the plugin's optionalzipfeature:tarandflate2dependencies are not optional, so the.app.tar.gzinstall path is unchanged. Thezipcrate was only ever a Windows dependency.update_guard.rsalready refuses installs on other platforms.zip,arbitraryandderive_arbitrarygoing away.If a Windows or Linux build ever ships, the feature has to come back, on plugin 2.14.1 or later. A comment beside the dependency says so.
Exposure: the
nextandundiciadvisories apply only to the Docker image's Node rollback (BACKEND=node) and development. The default Rust image and the desktop app serve a static build.Container image (
container-smoke's Trivy scan: 3 HIGH findings, all from the base image)container-smokeis skipped whilequalityfails, so these only surfaced once the fixes above let it run.ALPINE_IMAGEmoves from 3.24.2 to 3.24.4, pinned by digest. I read the package database out of that digest from the registry for amd64 and arm64, and both carry these versions. CI's scan is the first real run of Trivy against it.The Node rollback base (
node:24.20.0-alpine,BACKEND=node) still has musl 1.2.6-r2 and zlib 1.3.2-r0.container-smokedoes not scan that image, so it does not affect this PR, butdocker-publish.ymlwould refuse it on a release withbackend: node.Verified locally
pnpm audit --prodexits 0.cargo audit --fileexits 0 for all three lockfiles.tsc --noEmit, Biome (1056 files), i18n parity.tests/app: 1163 passed, 0 failed, 4 skipped.tests/release: 30 passed.cargo test --lockedforcore/andsrc-tauri/(macOS).next build --webpackon 16.4.5 withgenerate-csp-hashes(38 static routes).next start:security-headers,loading-shellandzz-csp-integrity, 11 passed.Not run locally: the full e2e suites, the Turbopack build CI uses (the local SSD setup forces webpack), a Linux compile of
src-tauriwithout the feature (the plugin's Linux path is feature-gated;rust-checkcovers it), and a signed release build of the updater.pnpm notices:rustregenerated both crate lists.lib/rust-crates.jsondid not change.🤖 Generated with Claude Code