Create TopBanner component - #1588
Merged
Merged
Conversation
doradocodes
commented
Aug 31, 2026
Comment on lines
+17
to
+34
| // const banner = document.querySelector('.banner'); | ||
| // const hideBannerBtn = document.querySelector('#hideBanner'); | ||
| // if (banner && hideBannerBtn) { | ||
| // const hiddenBanner = window.sessionStorage.getItem('hideBanner'); | ||
| // const title = banner.getAttribute('data-title'); | ||
| // if (hiddenBanner !== title) { | ||
| // banner.removeAttribute('style'); | ||
| // } | ||
| // const hideBanner = () => { | ||
| // banner.setAttribute('style', 'display: none'); | ||
| // try { | ||
| // window.sessionStorage.setItem('hideTopBanner', title || ''); | ||
| // } catch (e) { | ||
| // console.error(e); | ||
| // } | ||
| // } | ||
| // hideBannerBtn.addEventListener('click', hideBanner); | ||
| // } |
Contributor
Author
There was a problem hiding this comment.
@Nwakaego-Ego Need to add this code block back in, and be specific to the TopBanner element
doradocodes
commented
Aug 31, 2026
Comment on lines
+589
to
+590
| background-color: #1E32AA; | ||
| color: white; |
Contributor
Author
There was a problem hiding this comment.
@Nwakaego-Ego Currently, these are the Processing colors. I think we should make the component have dynamic colors. Which are passed through options in the en.md file.
Nwakaego-Ego
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a new component,
TopBanner, for additional announcements. Specifically to be used for the PCD annoucement.