Repository navigation
Open in-app browser links in a Custom Tab instead of the browser chooser when no default browser is set - #1630
Merged
Merged
Conversation
…ser when no default browser is set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the in-app browser selected, links (e.g. the source links inside Google News feed content) launched a Custom Tab without a target package, so on devices with several browsers and no default one Android showed the "Open with" chooser. The Custom Tab is now pinned to a Custom Tabs provider only when the system has no default handler for the link, leaving default-browser and verified app-link routing unchanged. Reproduced and verified on an API 36 emulator with two browsers and no default (chooser before, direct Custom Tab after), covered by InAppBrowserPackageTest; a Maestro flow isn't feasible because it needs a device with no default browser.