Repository navigation
Conversation
…lows the regex stack
Owner
Author
|
Closing as a duplicate of #1632, which has the same fix for JAVA-N1/JAVA-N2 plus a test that reproduces the overflow in Jewel's highlighter and a Compose test that fails without the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop reader crashed with a StackOverflowError (Sentry JAVA-N1/JAVA-N2, 1.19.0) when an article had a code block with a long string literal: Jewel's default SimpleCodeHighlighter matches literals with patterns like "(?:[^"\]|\.)*", which java.util.regex runs recursively once per character, and Jewel rethrows the error in the composition. The reader now passes its own highlighter that wraps SimpleCodeHighlighter and falls back to the plain code when it overflows. A Compose test that renders a fenced JSON block with a 200k-character string reproduced the crash and now passes, and the full detekt allTests gate is green.