fix(telnyx): guard voice timeout env values - #871
Open
aiirvizionz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NaN/invalid values to TelnyxWhy
The Telnyx voice gather payloads used
Number(process.env...)directly. If an env value is mistyped, JavaScript can produceNaN,Infinity, or non-positive timeout values that get serialized into the Telnyx request payload instead of falling back to safe defaults.Tests
node .\\node_modules\\.pnpm\\vitest@2.1.9_@types+node@22.19.17\\node_modules\\vitest\\vitest.mjs run sites/sh1pt.com/lib/telnyx-voice.test.ts(2 tests passed)git diff --checkNote:
pnpm exec vitest ...attempted a dependency install first and was blocked by the repo lockfile policy because@profullstack/autoblog@0.4.0has no tarball integrity field. The direct local Vitest invocation above ran the regression without changing versioned files.