fix(stripe): guard invalid webhook tolerance config - #873
Open
aiirvizionz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ webhookToleranceSeconds: 0 }escape hatch for disabling timestamp checks.NaNfalls back to the default tolerance instead of bypassing stale-signature protection.Validation
git diff --checkI attempted
pnpm vitest run packages/payments/stripe/src/index.test.tsandpnpm --filter @profullstack/sh1pt-payment-stripe typecheck, but this checkout stops during dependency preparation because the committed lockfile fails the active supply-chain policy:@profullstack/autoblog@0.4.0has no tarball integrity field. I did not modify the lockfile; the regression test is included for maintainers' normal CI/runtime.