Skip to content

fix(telnyx): guard invalid signature tolerance config - #877

Open
aiirvizionz wants to merge 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/telnyx-signature-tolerance-guard
Open

fix(telnyx): guard invalid signature tolerance config#877
aiirvizionz wants to merge 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/telnyx-signature-tolerance-guard

Conversation

@aiirvizionz

Copy link
Copy Markdown
Contributor

Summary

  • Normalize Telnyx signature tolerance config before using it for webhook timestamp checks.
  • Keep the default 300-second replay window when config receives invalid numeric values such as Infinity, NaN, or negatives.
  • Add a regression test showing an old but correctly signed Telnyx webhook is rejected when the configured tolerance is invalid.

Validation

  • git diff --check
  • node node_modules\vitest\vitest.mjs run packages/bots/telnyx/src/index.test.ts (8 tests passed)

I also attempted pnpm vitest run packages/bots/telnyx/src/index.test.ts and pnpm --filter @profullstack/sh1pt-bot-telnyx typecheck, but this checkout stops during dependency preparation because the committed lockfile fails the active supply-chain policy: @profullstack/autoblog@0.4.0 has no tarball integrity field. I did not modify the lockfile.

Copilot AI review requested due to automatic review settings July 29, 2026 04:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants