Add nfc-ethernet to PairingMode and DutPairingModeEnum - #108
Conversation
Mirrors the backend's app/constants/shared_constants.py so the CLI's enums stay in sync with the new NFC_ETHERNET pairing mode used for Matter-over-Ethernet commissioning over NFC in python_testing suites. Related: project-chip/certification-tool#1067
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe PR adds Possibly related issues
Merge Risk: ⚪ Minimal · up to This localized change keeps the CLI pairing-mode enums aligned with the backend and adds coverage for the new value; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
|
Tick the box to add this pull request to the merge queue (same as
|
|
@coderabbitai review full |
|
✅ Action performedFull review finished. |
Summary
Mirrors the backend's
nfc-ethernetDUT pairing mode addition so the CLI's enums stay in sync (see project-chip/certification-tool-backend#351).Changes
th_cli/shared_constants.py: addedNFC_ETHERNET = "nfc-ethernet"toDutPairingModeEnumand toNFC_PAIRING_MODES.th_cli/config.py: addedNFC_ETHERNETto thePairingModeenum (currently unused for validation, kept in sync with the backend enum).tests/test_config.py: addedtest_nfc_ethernet_value.Out of scope
Related: project-chip/certification-tool#1067