refactor context menus into one shared widget, increase size a bit - #992
Merged
Merged
Conversation
context menus were mostly duplicated code across the room one and the message one, now they're combined. We also made them a bit larger to match the size and spacing of the room input popup menu, which looked better.
We had it for messages, now we do the same for rooms. It's also now activated upon touch-down (important for mobile) and then deactivated when the context menu is closed. also, make that gray highlight effect a tiny bit darker so that it shows up better on lower-contrast screens, and also remains visibile behind the context menu's darkening overlay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context menus were mostly duplicated code across the room one and the message one, now they're combined.
We also made them a bit larger to match the size and spacing of the room input popup menu, which looked better.